Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): lists page state management #128

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Dec 6, 2023

Description

Closes #109

Query parameters have been added to the URL whenever a section is opened on the lists page, making it navigable through the browser history stack. Examples of decoded urls :

/lists?section=tv-topics&bu=rts&nodes=urn:rts:topic:tv:665
/lists?section=radio-shows&bu=rts&nodes=a9e7621504c6959e35c3ecbe7f6bed0446cdf8da,urn:rts:show:radio:9801398

Changes made

Refactor the state management of the lists page to introduce the ListsPageStateManager class. This class facilitates navigation and retrieval of section data.

@jboix jboix requested a review from amtins December 6, 2023 09:41
Copy link

github-actions bot commented Dec 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 98.37% 482/490
🟢 Branches 93.44% 228/244
🟢 Functions 100% 136/136
🟢 Lines 99.15% 465/469

Test suite run success

145 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 5fe5495

demo/src/index.js Outdated Show resolved Hide resolved
demo/src/core/router.js Outdated Show resolved Hide resolved
demo/src/core/router.js Outdated Show resolved Hide resolved
Closes #109

Refactor the state management of the lists page to introduce the `ListsPageStateManager`
class. This class facilitates navigation and retrieval of section data. Query parameters
have been added to the URL whenever a section is opened on the lists page, making it navigable
through the browser history stack. Examples of decoded urls :

```text
/lists?section=tv-topics&bu=rts&nodes=urn:rts:topic:tv:665
/lists?section=radio-shows&bu=rts&nodes=a9e7621504c6959e35c3ecbe7f6bed0446cdf8da,urn:rts:show:radio:9801398
```
@jboix jboix force-pushed the feat/109-list-page-state branch from 1c398a4 to 5fe5495 Compare December 6, 2023 13:42
@jboix jboix requested a review from amtins December 6, 2023 13:44
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 8eb2ca0 Dec 6, 2023
3 checks passed
@jboix jboix deleted the feat/109-list-page-state branch December 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo application state
2 participants