fix(pillarbox-monitoring): inconsistent error name value #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #283, by modifying the value of the error name sent, allowing clearer errors when consumed by other tools. This modification supports the properties as defined by the WHATWG as well as the two custom properties provided by video.js which are `MEDIA_ERR_CUSTOM` and `MEDIA_ERR_ENCRYPTED`. - add a static method for setting the value of the error name - add mock for `MediaError`
|
Coverage report
Test suite run success247 tests passing in 10 suites. Report generated by 🧪jest coverage report action from 722dde6 |
amtins
deleted the
fix/283-inconsistent-monitoring-error-message-payload
branch
|
🎉 This PR is included in version 1.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #283, by modifying the value of the error name sent, allowing clearer errors when consumed by other tools.
This modification supports the properties as defined by the WHATWG as well as the two custom properties provided by video.js which are
MEDIA_ERR_CUSTOMandMEDIA_ERR_ENCRYPTED.Changes made
MediaError