fix(srgssr-middleware): geoblocked mediaComposition without resourceList #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest IL update removes the `resourceList` object from geo-blocked `mediaComposition`. This change in behavior, even though the `resourceList` object is not a mandatory object, causes the player to return a non-compatible content error instead of a geoblock error. - modify `getSrcMediaObj` so that `mediaData` contains an object containing `blockReason` and `imageUrl` if `mainResources` is empty. - add test case
|
Coverage report
Test suite run success248 tests passing in 10 suites. Report generated by 🧪jest coverage report action from 02c75d9 |
defagos
approved these changes
Jan 24, 2025
amtins
deleted the
fix/geoblocked-mediaComposition-without-resourceList
branch
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest IL update removes the
resourceListobject from geo-blockedmediaComposition. This change in behavior, even though theresourceListobject is not a mandatory object, causes the player to return a non-compatible content error instead of a geoblock error.Changes made
getSrcMediaObjso thatmediaDatacontains an object containingblockReasonandimageUrlifmainResourcesis empty.