feat(remaining-time-display): displays remaining time in x-small or tiny #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the current time and media duration are displayed, it's easy for the user to visualize the time remaining to play. However, when the player is displayed in x-small or tiny, no time indication is shown. - modify `_layout.scss` to display the remaining time when the player is displayed in x-small or tiny.
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success247 tests passing in 10 suites. Report generated by 🧪jest coverage report action from 7dedb56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the current time and media duration are displayed, it's easy for the user to visualize the time remaining to play. However, when the player is displayed in x-small or tiny, no time indication is shown.
Changes made
_layout.scssto display the remaining time when the player is displayed in x-small or tiny