Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/#269 Added onMouseUp Event #589

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vedhapre
Copy link

@vedhapre vedhapre commented Dec 16, 2021

Description

Adds feature requested in Issue #269. Added onMouseUp event for non-touch functionality.

Motivation and Context

Issue #269
#269
The requester wanted to emit separate events for touch and swipe, so this adds a touch and non-touch click with the onMouseUp.

How Has This Been Tested?

Tested by using vue-play and thoroughly testing both on own instance of carousel as well as vue-play.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have included a vue-play example (if this is a new feature)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant