無限シュートのテストを移植 #152
Merged
無限シュートのテストを移植 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uchikun2493
reviewed
Dec 30, 2023
Comment on lines
31
to
34
| def shoot_to_their_test(robot_id: int): | ||
| operation = OneShotOperation().move_to_pose(TargetXY.ball(), TargetTheta.look_ball()) | ||
| operation = operation.with_shooting_to(TargetXY.their_goal()) | ||
| operator_node.operate(robot_id, operation) |
There was a problem hiding this comment.
これは何をする関数なのかコメント入れてほしいな
できたら各行何してるのかも書いてあるとベスト
Comment on lines
47
to
48
| arg_parser.add_argument('-robot_id', default=0) | ||
| args = arg_parser.parse_args() |
There was a problem hiding this comment.
-robot_idの省略系がほしい
例えば--robot_idにしておいて省略系を-idにするとか
uchikun2493
reviewed
Dec 30, 2023
Comment on lines
50
to
51
| arg_parser.add_argument('-id', default=0) | ||
| args = arg_parser.parse_args() |
There was a problem hiding this comment.
arg_parser.add_argument('-id', default=0)→arg_parser.add_argument('--robot_id', '-id', type=int, default=0)みたいにするのがいいかな
args.robot_idでひっぱってこれる
uchikun2493
reviewed
Dec 30, 2023
Comment on lines
68
to
69
| try: | ||
| shoot_to_their_test(int(args.robot_id)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ロボットIDをコマンドで指定できるようにしてある