Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam: only set SYSDB_LOCAL_SMARTCARD_AUTH to 'true' but never to 'false'. #7602

Closed
wants to merge 1 commit into from
Closed

pam: only set SYSDB_LOCAL_SMARTCARD_AUTH to 'true' but never to 'false'. #7602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/responder/pam/pamsrv_cmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,22 @@ static errno_t set_local_auth_type(struct pam_auth_req *preq,
goto fail;
}

ret = sysdb_attrs_add_bool(attrs, SYSDB_LOCAL_SMARTCARD_AUTH, sc_allow);
if (ret != EOK) {
goto fail;
if (sc_allow) {
/* Only set SYSDB_LOCAL_SMARTCARD_AUTH to 'true' but never to
* 'false'. The krb5 backend will only returns that Smartcard
* authentication is available if a Smartcard is present. That means
* if the user authenticates with a different method and a Smartcard
* is not present at this time 'sc_allow' will be 'false' and might
* overwrite a 'true' value written during a previous authentication
* attempt where a Smartcard was present. To avoid this we only write
* 'true' values. Since the default if SYSDB_LOCAL_SMARTCARD_AUTH is
* missing is 'false' local Smartcard authentication (offline) will
* still only be enabled if online Smartcard authentication was
* detected. */
ret = sysdb_attrs_add_bool(attrs, SYSDB_LOCAL_SMARTCARD_AUTH, sc_allow);
if (ret != EOK) {
goto fail;
}
}

ret = sysdb_attrs_add_bool(attrs, SYSDB_LOCAL_PASSKEY_AUTH, passkey_allow);
Expand Down
Loading