Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ming] Chapter10_API & Pagin #43

Merged
merged 3 commits into from
Jun 27, 2024
Merged

[ming] Chapter10_API & Pagin #43

merged 3 commits into from
Jun 27, 2024

Conversation

qzzloz
Copy link
Member

@qzzloz qzzloz commented Jun 26, 2024 •
edited
Loading

#️⃣ 연관된 이슈


✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@qzzloz qzzloz added the ✨ Chapter10 챕터 10 label Jun 26, 2024
@qzzloz qzzloz self-assigned this Jun 26, 2024
@qzzloz qzzloz requested review from ryogaeng and Gusionling June 26, 2024 13:57
ryogaeng
ryogaeng approved these changes Jun 26, 2024
View reviewed changes
Copy link

@ryogaeng ryogaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그동안 스터디 진행하시느라 고생 많으셨습니다! 앞으로 더 멋있는 개발자가 되길 응원할게요 :)

Gusionling
Gusionling approved these changes Jun 27, 2024
View reviewed changes
Copy link

@Gusionling Gusionling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@qzzloz qzzloz merged commit 927be17 into ming/main Jun 27, 2024
@qzzloz qzzloz deleted the ming/#31 branch June 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryogaeng ryogaeng ryogaeng approved these changes

@Gusionling Gusionling Gusionling approved these changes

Assignees

@qzzloz qzzloz

Labels
✨ Chapter10 챕터 10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qzzloz @ryogaeng @Gusionling