Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sof] Chapter10_API & Paging #44

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[sof] Chapter10_API & Paging #44

merged 2 commits into from
Jun 27, 2024

Conversation

ryogaeng
Copy link

#️⃣ 연관된 이슈

#31

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@ryogaeng ryogaeng added the ✨ Chapter10 챕터 10 label Jun 26, 2024
@ryogaeng ryogaeng requested review from qzzloz and Gusionling June 26, 2024 12:45
@ryogaeng ryogaeng self-assigned this Jun 26, 2024
Gusionling
Gusionling reviewed Jun 26, 2024
View reviewed changes
Copy link

@Gusionling Gusionling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageRequest.of메서드를 사용하던데 size가 10으로 하드코딩 되어 있는 것 같은데 맞나요?
이 부분이 유연성 측면에서 런타임에 동적으로 바꿀 수 있는 방법이 있는지 궁금합니다.

qzzloz
qzzloz approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@qzzloz qzzloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 주도 수고하셨습니다!!

Gusionling
Gusionling approved these changes Jun 27, 2024
View reviewed changes
Copy link

@Gusionling Gusionling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@ryogaeng ryogaeng merged commit 9e5a897 into sof/main Jun 27, 2024
@ryogaeng ryogaeng deleted the sof/#31 branch June 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qzzloz qzzloz qzzloz approved these changes

@Gusionling Gusionling Gusionling approved these changes

Assignees

@ryogaeng ryogaeng

Labels
✨ Chapter10 챕터 10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryogaeng @qzzloz @Gusionling