-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gasnet-related test failures #6377
Conversation
2f9f5a8
to
e6dcbe3
Compare
retest lsu |
@Pansysk75 LGTM |
@Pansysk75 Something is wrong here, see the failing tests, please. |
cmake/HPX_AddTest.cmake
Outdated
set_tests_properties( | ||
"${_full_name}" PROPERTIES RUN_SERIAL TRUE ENVIRONMENT | ||
"GASNET_PSHM_NODES=2" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this environment variable added only if running using the gasnet parcelport?
@ct-clmsn |
@Pansysk75
HPX is throwing |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
bb129d1
to
a1edead
Compare
@Pansysk75 what's the status with this PR? |
Still in progress (no particular blockers), I'll have a look as soon as I get the opportunity. |
a1edead
to
833feac
Compare
240d266
to
b07b2ed
Compare
@hkaiser I think we should merge this so that other PRs get tested properly (Assuming I didn't mess up anything else). Since gasnet might need some more work, I removed it from the testing for now, so that the tests give somewhat meaningful results. |
Tests were broken (not running) due to an environment variable being set incorrectly.
@ct-clmsn Would this be ok?