New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cover command err rc >= 124 like in scale-up #124

Merged

fmherschel merged 1 commit into SUSE:master from ja9fuchs:fix-rc-over-124

Jun 6, 2024

Contributor

ja9fuchs commented Jun 5, 2024

As discussed in SUSE/SAPHanaSR#248.

Similar to the classic scale-up SAPHanaTopology code, this change includes coverage of RCs >=124 in the sht_monitor_clone function only.

This prevents the role attributes from being updated in case of command errors, which otherwise leads to invalid role values and causes a failover.

Replaced one -eq 124 with -ge 124.
Updated the log messages to a more generic error, not only timeout.
Added the RC to the log messages.
Replaced != 124 with -lt 124 to exclude the same range of 124+.


          cover command err rc >= 124 like in scale-up

aeebe92

fmherschel approved these changes

View reviewed changes

Member

fmherschel left a comment

Looks good for me, thanks!

fmherschel merged commit b77e008 into SUSE:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet