HANA_CALL - cdpy issue #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HDBSetiings.sh is introducing a command chain for the python scripts "cdpy; python ....py" a) cdpy is not found b) inner timeout is only applied to 1st command .. here cdpy and not the command chain 2 Options A) either get rid of inner timeout at all B) use pre_script variable as offered by this PR
|
Problem: Aliases are not always expanded within scripts !!! In case sidadm is using posix shell (e.g. login shell /bin/sh) an alias is expanded. In case of /bin/bash it is not !!! That's the reason why it is sometimes available and sometimes not. # /bin/sh -c "shopt expand_aliases"
expand_aliases on
# /bin/bash -c "shopt expand_aliases"
expand_aliases off
# /bin/bash -O expand_aliases -c "shopt expand_aliases"
expand_aliases onWe have to either ensure that the cdpy alias is expanded or we just don't use the alias .. su - <sid>adm -s /bin/sh -c "(cdpy; python landscapeHostConfiguration.py)"
su - <sid>adm -c "(shopt -s expand_aliases; eval cdpy; python landscapeHostConfiguration.py)"
su - <sid>adm -c '(cd $DIR_INSTANCE/exe/python_support; python landscapeHostConfiguration.py)' |
PeterPitterling
changed the title
angelabriel
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the recent changes to avoid HDBSettings introduced 2 issues
a) cdpy is not found as highlighted in #121 and #122
b) inner timeout is only applied to 1st command; here cdpy and not the command chain
to fix a) see comments below
to fix b) cdpy or similar could be used within pre_script as provided by this PR