Enable flake8 on the UT code (#241)

Enable flake8 on the test/unit folder
Add it to github workflow for PR
Change flake8 requirements to avoid issue in Python 3.12 due to
PyCQA/flake8#1845
Fix some warnings in the test code.

.github/workflows/gluescript.yml

@@ -38,6 +38,12 @@ jobs:
       run: tox -e flake8
       env:
         PLATFORM: ${{ matrix.platform }}
+    - name: flake8 test code with tox
+      working-directory: scripts/qesap/
+      run: |
+        tox -e flake8_test
+      env:
+        PLATFORM: ${{ matrix.platform }}
     - name: UT tox
       working-directory: scripts/qesap/
       run: tox

scripts/qesap/requirements-dev.txt

@@ -1,4 +1,4 @@
-flake8==6.0.*
+flake8>=6.0.*
 flake8-bugbear==23.5.*
 hypothesis==6.*
 pylint==3.1.*

scripts/qesap/test/unit/test_qesap_lib_cmd_ansible.py

@@ -1,4 +1,3 @@
-from unittest import mock
 import logging
 import os
 
@@ -9,18 +8,29 @@
 
 
 def test_export_ansible_output():
-    '''
+    """
     Utility function that get the ansible command line and the command output.
     Function calculate the log name by extracting the ansible playbook name from the command line.
     Function take the content of out and write it to a file in the current directory
-    
-    '''
+    """
 
     test_dir = os.getcwd()
-    test_file = os.path.join(test_dir, 'ansible.testAll.log.txt')
-    command_to_sent = {'test1':'test_value1', 'test2':'test_value2', 'test3':'test_value3', 'test4':'test_value4',
-                        'cmd':['/tmp/exec_venv/bin/ansible', '-vvvv', '-i', '/root/qe-sap-deployment/terraform/aws/inventory.yaml',
-                              '/some/immaginary/path/testAll.yaml', '-a', '--ssh-extra-args="-l cloudadmin -o UpdateHostKeys=yes -o StrictHostKeyChecking=accept-new"']}
+    test_file = os.path.join(test_dir, "ansible.testAll.log.txt")
+    command_to_sent = {
+        "test1": "test_value1",
+        "test2": "test_value2",
+        "test3": "test_value3",
+        "test4": "test_value4",
+        "cmd": [
+            "/tmp/exec_venv/bin/ansible",
+            "-vvvv",
+            "-i",
+            "/root/qe-sap-deployment/terraform/aws/inventory.yaml",
+            "/some/immaginary/path/testAll.yaml",
+            "-a",
+            '--ssh-extra-args="-l cloudadmin -o UpdateHostKeys=yes -o StrictHostKeyChecking=accept-new"',
+        ],
+    }
     ansible_output = """DEBUG    OUTPUT: ansible [core 2.13.5]
                         DEBUG    OUTPUT:   config file = None
                         DEBUG    OUTPUT:   configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']

scripts/qesap/test/unit/test_qesap_lib_cmd_terraform.py

@@ -187,4 +187,4 @@ def test_cmd_terraform(subprocess_run, tmpdir):
 
     assert ret == 0
 
-    subprocess_run.assert_has_calls(calls)
+    subprocess_run.assert_has_calls(calls)

scripts/qesap/tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py39,py310,py311,flake8,pylint
+envlist = py{39,310,311,312},flake8,pylint
 skipsdist = True
 
 [gh-actions]
@@ -11,11 +11,13 @@ python =
 
 [testenv:flake8]
 deps = -r{toxinidir}/requirements-dev.txt
-commands = flake8 qesap.py lib/
+commands = flake8 --version
+           flake8 qesap.py lib/
 
 [testenv:flake8_test]
 deps = -r{toxinidir}/requirements-dev.txt
-commands = flake8 test/
+commands = flake8 --version
+           flake8 test/
 
 [testenv:pylint]
 deps = -r{toxinidir}/requirements-dev.txt