Remove machine type default from AWS #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terrafor AWS code variables has default about machine type in two place: - HIGH: in the main variables.tf - LOW: in each module variable.tf It is problematic to maintain these two level of defaults with the same values. Removing defaults from the HIGH level result in all machine types variables to become mandatory in the terraform.tfvars and so in the conf.yaml. Thic commit remove defaults from LOW level. Doing so does not change user experience as HIGH levels will always provide value to them from user tfvars file ir default. This commit also ensure that each description field is at the first place if available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform AWS code variables has default about machine type in two place:
Removing defaults from the HIGH level result in all machine types variables to become mandatory in the terraform.tfvars and so in the conf.yaml.
This commit remove defaults from LOW level. Doing so does not change user experience as HIGH levels will always provide value to LOW level from user tfvars file or default.
This commit also ensure that each description field is at the first place if available.
Ticket https://jira.suse.com/browse/TEAM-7678
Verification