Drop conf.yaml apiver support #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarocarvajald
approved these changes
Aug 29, 2024
scripts/qesap/lib/cmds.py
Outdated
| if 'az_sas_token' in config_ansible: | ||
| hanamedia_content['az_sas_token'] = config_ansible['az_sas_token'] | ||
| hanamedia_content['az_blobs'] = config_ansible['hana_media'] | ||
| log.error("Apiver:%d is no more supported", apiver) |
There was a problem hiding this comment.
s/is no more supported/is no longer supported/
scripts/qesap/lib/config.py
Outdated
| return False | ||
| if 'az_container_name' not in ansible_conf: | ||
| log.error("Missing 'az_container_name' in 'ansible' in the config") | ||
| log.error("Apiver: %d is no more supported", apiver) |
There was a problem hiding this comment.
s/is no more supported/is no longer supported/
|
|
||
| def test_configure_apiver_older_than_3_no_ansible(base_args, tmpdir): | ||
| ''' | ||
| Test is using th eno more supported apiver:2 |
There was a problem hiding this comment.
s/Test is using th eno more supported apiver:2/Test is using the unsupported apiver:2/
mpagot
force-pushed
the
qesap_drop_apiver_2
branch
from
45c2900 to
02c15a4
Compare
Drop support for apiver <3
mpagot
force-pushed
the
qesap_drop_apiver_2
branch
from
02c15a4 to
ab50889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for apiver <3
apiver 3 has been introduced in qe-sap-deployment version 0.5.0 with #103
Verification
HANASR http://openqaworker15.qa.suse.cz/tests/295671
QESAP http://openqaworker15.qa.suse.cz/tests/295672