Run aws set_facts conditionally #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpagot
reviewed
Sep 3, 2024
BillAnastasiadis
force-pushed
the
gcp_aws_mix
branch
from
bb38c10 to
203ffc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set corosync factsincluster_bootstrap.yamlis being run for both aws and gcp, but only applies to aws, uses an aws-specific variable and that causes gcp tests to fail due to missing variable. This pr conditionally runs the task, only if platform is aws.http://openqaworker15.qa.suse.cz/tests/296118 (passed the point of trouble, fails due to native fencing not working)
http://openqaworker15.qa.suse.cz/tests/296122 (PASS, sbd implementation)