-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCP peering to terraform #301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillAnastasiadis
temporarily deployed
to
production
December 4, 2024 11:48 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 4, 2024 11:48 — with
GitHub Actions
Inactive
BillAnastasiadis
had a problem deploying
to
production
December 4, 2024 12:12 — with
GitHub Actions
Failure
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 4, 2024 12:46
a38ce8c
to
1e0f893
Compare
BillAnastasiadis
had a problem deploying
to
production
December 4, 2024 12:46 — with
GitHub Actions
Failure
BillAnastasiadis
had a problem deploying
to
production
December 4, 2024 12:46 — with
GitHub Actions
Error
BillAnastasiadis
temporarily deployed
to
production
December 4, 2024 12:46 — with
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 4, 2024 13:00
1e0f893
to
c1e2e91
Compare
BillAnastasiadis
temporarily deployed
to
production
December 4, 2024 13:00 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 4, 2024 13:00 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 4, 2024 13:00 — with
GitHub Actions
Inactive
a-kpappas
previously requested changes
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
alvarocarvajald
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jankohoutek
reviewed
Dec 4, 2024
jankohoutek
reviewed
Dec 4, 2024
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 5, 2024 17:34
c1e2e91
to
c66e10d
Compare
BillAnastasiadis
had a problem deploying
to
production
December 5, 2024 17:34 — with
GitHub Actions
Error
BillAnastasiadis
had a problem deploying
to
production
December 5, 2024 17:34 — with
GitHub Actions
Failure
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:34 — with
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 5, 2024 17:35
c66e10d
to
bdcf241
Compare
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:36 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:36 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:36 — with
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 5, 2024 17:38
bdcf241
to
e2d1d8a
Compare
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:38 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:38 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:38 — with
GitHub Actions
Inactive
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 5, 2024 17:56
e2d1d8a
to
9e57015
Compare
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:56 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:56 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 5, 2024 17:56 — with
GitHub Actions
Inactive
mpagot
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BillAnastasiadis
force-pushed
the
gcp_peering
branch
from
December 6, 2024 08:11
9e57015
to
4855273
Compare
BillAnastasiadis
temporarily deployed
to
production
December 6, 2024 08:11 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 6, 2024 08:11 — with
GitHub Actions
Inactive
BillAnastasiadis
temporarily deployed
to
production
December 6, 2024 08:11 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr conditionally adds peering with IBSM to GCP innside terraform, during resource creation. Nothing else will need to be done for the creation or the destruction of the peering (it will be managed exclusively by terraform). If the control variable `` doesn't exist, it defaults to false, and the deployment continues as before without creating the peering or related resources.
To make use of this and create a deployment with IBSM Peering, user (or openqa) needs to provide the following variables in config.yaml:
And that's it. By providing those 4 variables, the hana nodes will be created peered with gcp IBSM, and the peering and related resources will be automaticlly destroyed when terraform destroy is called.
https://openqaworker15.qa.suse.cz/tests/305879 (this is without any of the new variables set - so no peering or associated resources are created, and test runs like before)