Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP peering to terraform #301

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

BillAnastasiadis
Copy link
Collaborator

@BillAnastasiadis BillAnastasiadis commented Dec 4, 2024

This pr conditionally adds peering with IBSM to GCP innside terraform, during resource creation. Nothing else will need to be done for the creation or the destruction of the peering (it will be managed exclusively by terraform). If the control variable `` doesn't exist, it defaults to false, and the deployment continues as before without creating the peering or related resources.

To make use of this and create a deployment with IBSM Peering, user (or openqa) needs to provide the following variables in config.yaml:

enable_ibsm_peering: 'true'
ibsm_vpc_name: '<gcp mirror vpc name>'
ibsm_subnet_name: '<gcp mirror subnet name>'
ibsm_subnet_region: '<gcp mirror region>'

And that's it. By providing those 4 variables, the hana nodes will be created peered with gcp IBSM, and the peering and related resources will be automaticlly destroyed when terraform destroy is called.

terraform/gcp/infrastructure.tf Outdated Show resolved Hide resolved
terraform/gcp/variables.tf Outdated Show resolved Hide resolved
terraform/gcp/variables.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants