Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav changes #154

Merged
merged 14 commits into from
Apr 26, 2019
Merged

Sidenav changes #154

merged 14 commits into from
Apr 26, 2019

Conversation

KlapTrap
Copy link

  1. Remove sidenav hover
  2. Have icon mode and full mode only
  3. Default to full mode
  4. Move burger icon into the side nav header
  5. Remove the icon logo

richard-cox
richard-cox requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Gripper is not visible on mobile sizes
  • Odd blip of side nav when shrinking/growing browser width
  • Tweaks as per discussion
  • Future work - sticky collapsed state over sessions

@richard-cox richard-cox added the needs attention Needs attention label Apr 25, 2019
@richard-cox richard-cox mentioned this pull request Apr 25, 2019
Closed
@codecov-io
Copy link

codecov-io commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #154 into v2-master will increase coverage by 0.02%.
The diff coverage is 87.5%.

@@              Coverage Diff              @@
##           v2-master     #154      +/-   ##
=============================================
+ Coverage      53.08%   53.11%   +0.02%     
=============================================
  Files            849      849              
  Lines          22339    22345       +6     
  Branches        3812     3811       -1     
=============================================
+ Hits           11859    11868       +9     
+ Misses         10480    10477       -3

@KlapTrap KlapTrap added ready for review Ready for review and removed needs attention Needs attention labels Apr 26, 2019
@KlapTrap KlapTrap requested a review from richard-cox April 26, 2019 14:50
nwmac
nwmac approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit f08fcb5 into v2-master Apr 26, 2019
@nwmac nwmac deleted the sidenav-changes branch April 26, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

@richard-cox richard-cox richard-cox approved these changes

Assignees
No one assigned
Labels
in review ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KlapTrap @codecov-io @nwmac @richard-cox