Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream merge #166

Merged
merged 9 commits into from
Apr 30, 2019
Merged

Upstream merge #166

merged 9 commits into from
Apr 30, 2019

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Apr 30, 2019

No description provided.

Nathan and others added 9 commits April 29, 2019 14:42
…fix-valdiation

Fix SSO connect button not enabled
…y#3545)

* Remove missing onEnter

* Correctly update appsEmitted given changes in selectors
- current implementation was put in place to ensure skipApps$ resolves before we continue to the next step
- there was a bug where if user returns to step then continues again, as nothing had changed, onNext would never resolve
- now move appsEmitted to more core observable

* Enable next only if there's been a change
…ota (cloudfoundry#3541)

* When no space quota has been assigned fall back on more realistive quota
- before, if no space quota was found, a rough match for the default quota was used
- this missed the `paid service plan` property
- now, before falling back on the 'infinite' quota, try to use the more realistive org quota

* Fix unit test
…ourse-fix

Concourse Pipeline: Fix to ensure "make-release" works with a private GitHub Repository
* Remove firefox specific fade text overflow

* Added comment
@nwmac nwmac added the ready for review Ready for review label Apr 30, 2019
@nwmac nwmac self-assigned this Apr 30, 2019
@nwmac nwmac merged commit e0df313 into v2-master Apr 30, 2019
@nwmac nwmac deleted the upstream-merge branch April 30, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants