forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #374
Merged
Merged
Merge upstream #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backup/Restore endpoints & tokens
- When apps collection is fetched and exceeds maxed allowed certain monitor observables were still firing with the partial collection of apps - This led to app based stats (like count and memory) to be shown on the space cards & summary - This was caused by a correction to the pagination monitor to use 'local' monitor observables instead of non-local - The now correct observable to use did not have a filter for maxed results, so emited the bad data
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 58.51% 59.32% +0.80%
==========================================
Files 1039 1047 +8
Lines 33108 33423 +315
Branches 4559 4588 +29
==========================================
+ Hits 19372 19827 +455
+ Misses 13736 13596 -140 |
- wasn't showing after list in list changes - fixes cloudfoundry#4243
CF Push: Ensure we refresh token
…nto merge-upstream
- pushes route over max 63 chars
- pushes route over max 63 chars
E2E Improvements
…nto merge-upstream
* Speed up form fill * Manage users fix? * Wait slightly longer * Improve error output in tests * Fix invite users error msg check * Fix manage users e2e * Need checked in form to check box correctly
* Fix row highlight (see app github tab commit table) - wasn't showing after list in list changes - fixes cloudfoundry#4243 * Improve metrics view * Fix code climate issues * Fix 2 more code climate issues * Fix merge issue * Fix dark mode box shadow - dark mode styling overode disabling of box shadow * Fix multiple metrics requests due to recreated list cards * Fix most additional /stratos requests on load of endpoints page with metrics * Fix unit tests * Fix EndpointCardComponent test * Fix root list colour in metrics summary page dark mode * Fix first row alignment in users table * Fix invite user e2e test (see cloudfoundry#4272) * Disable random route override setting when deploying apps in e2e tests - pushes route over max 63 chars Co-authored-by: Neil MacDougall <[email protected]>
…4258) * Improve metrics view * Fix code climate issues * Fix 2 more code climate issues * Fix merge issue * Fix multiple metrics requests due to recreated list cards * Fix most additional /stratos requests on load of endpoints page with metrics * Fix unit tests * Fix EndpointCardComponent test Co-authored-by: Richard Cox <[email protected]>
* Fix row highlight (see app github tab commit table) - wasn't showing after list in list changes - fixes cloudfoundry#4243 * Fix dark mode box shadow - dark mode styling overode disabling of box shadow Co-authored-by: Neil MacDougall <[email protected]>
* E2E Cleanup script: clean other users and reduce time to 1 hour * Remove superfluous blank lines * Revert back to 2 hours
* Speed up form fill * Fix page set setting * Remove whitespace
Version bump and change log for 3.2.0
a647336
to
3af8cf0
Compare
nwmac
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.