Fix upgrade not showing when an RC is deployed #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
+ Coverage 57.80% 57.85% +0.04%
==========================================
Files 1061 1061
Lines 34403 34418 +15
Branches 4891 4898 +7
==========================================
+ Hits 19888 19912 +24
+ Misses 14515 14506 -9 |
richard-cox
requested changes
Oct 5, 2020
| @@ -0,0 +1,28 @@ | |||
| import { Version } from './helm-release-helper.service'; | |||
|
|
|||
| fdescribe('HelmReleaseHelperService', () => { | |||
| @@ -224,6 +245,8 @@ export class HelmReleaseHelperService { | |||
| if (c.relationships && c.relationships.latestChartVersion && c.relationships.latestChartVersion.data) { | |||
| const latest = new Version(c.relationships.latestChartVersion.data.version); | |||
| const current = new Version(release.chart.metadata.version); | |||
| console.log(latest); | |||
richard-cox
approved these changes
Oct 5, 2020
|
I'm going to merge this to unblock downstream merge. Unit tests have passed and the only other change is removal of logging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512