Add validation when connecting Kubernetes endpoints #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2-master #94 +/- ##
==========================================
Coverage 71.92% 71.92%
==========================================
Files 685 685
Lines 29583 29583
Branches 6787 6787
==========================================
Hits 21277 21277
Misses 8306 8306 |
richard-cox
requested changes
Nov 15, 2018
| @@ -59,6 +59,19 @@ func (c *KubernetesSpecification) Register(echoContext echo.Context) error { | |||
| return c.portalProxy.RegisterEndpoint(echoContext, c.Info) | |||
| } | |||
|
|
|||
| func (c *KubernetesSpecification) Validate(userGUID string, cnsiRecord interfaces.CNSIRecord, tokenRecord interfaces.TokenRecord) error { | |||
| response, err := c.portalProxy.DoProxySingleRequest(cnsiRecord.GUID, userGUID, "GET", "api/v1/pods") | |||
There was a problem hiding this comment.
We might want to apply a limit param of 1 to this (see https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#list-all-namespaces-pod-v1-core), otherwise we could get a huge amount of data back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Validate function to the endpoint plugin that is called as part of the Connect flow.
Allows an endpoint plugin to check that the authentication provided is valid.
Fixes #91