Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build #427

Merged
merged 75 commits into from
Sep 23, 2020
Merged

New build #427

merged 75 commits into from
Sep 23, 2020

Conversation

jfhenon
Copy link
Collaborator

@jfhenon jfhenon commented Aug 6, 2020

PR description

This PR has the goal to simplify the build process using the latest rollup/babel updates offering modern browsers light solution but also keeping support for older browsers.
We may also include in this PR some npm packages that are now imbedded in the project and not updated (which ultimately can cause bugs and security issues).

NOT READY TO MERGE BUT FOR INITIAL COMMENTS/CONTRIBUTIONS

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

@jfhenon jfhenon requested a review from brettz9 August 6, 2020 20:04
@jfhenon
Copy link
Collaborator Author

jfhenon commented Aug 6, 2020

should add to the documentation:

@jfhenon
Copy link
Collaborator Author

jfhenon commented Aug 7, 2020

Now, css and modules are added using standard css3/es6 syntax. It works well with esm but not tested on old browser.

Copy link
Contributor

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't dived too deeply into the details of the Rollup process yet, as I'd like to request these more ancillary changes first and then if all the editors are ready to be tested, I can check at that point.

But it generally looks good and more elegant if it meets the needs of all of our editors, and if the issues I raised can be addressed.

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/editor/extensions/ext-mathjax.js Outdated Show resolved Hide resolved
src/editor/spinbtn/jQuery.SpinButton.js Show resolved Hide resolved
src/editor/svg-editor.manifest Show resolved Hide resolved
src/editor/svgedit.js Outdated Show resolved Hide resolved
src/xdomain-svgedit-config-es.js Outdated Show resolved Hide resolved
src/svgcanvas/svgcanvas.js Outdated Show resolved Hide resolved
@jfhenon
Copy link
Collaborator Author

jfhenon commented Aug 8, 2020

I haven't dived too deeply into the details of the Rollup process yet, as I'd like to request these more ancillary changes first and then if all the editors are ready to be tested, I can check at that point.

But it generally looks good and more elegant if it meets the needs of all of our editors, and if the issues I raised can be addressed.

Yep, this was my intention to have a brief feedback from you. This will also takes some time before I can complete this.

Copy link
Contributor

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to import sounds good if it will work (I can't remember why I didn't go this route). See my other comments.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
dist/editor/index.html Outdated Show resolved Hide resolved
dist/editor/index.html Show resolved Hide resolved
src/editor/index.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jfhenon
Copy link
Collaborator Author

jfhenon commented Aug 13, 2020

The change to import sounds good if it will work (I can't remember why I didn't go this route). See my other comments.

I'm still struggling to find a way to configure Rollup properly for old browsers (nomodule). I think I progress slowly. I'm more familiar with webpack so would you have an issue if I test it on this one?

@brettz9
Copy link
Contributor

brettz9 commented Aug 13, 2020

Ugh--I'm sorry but Webpack really has struck me the times I've had to use it as unnecessarily complex, and that seems to be a common view. Webpack also doesn't support ESM distributions--only ESM source.

What nomodule issue are you looking to address? One useful plugin is https://github.com/rollup/plugins/tree/master/packages/replace (or some other third party Rollup plugins that do replacing) which you might use to strip out some input in one build or another, though that is for within JS only I think (not sure if any of the HTML/asset plugins do replacements).

@jfhenon
Copy link
Collaborator Author

jfhenon commented Aug 13, 2020

Ok. Let's stick to Rollup.

@jfhenon jfhenon merged commit 616f003 into master Sep 23, 2020
@jfhenon jfhenon deleted the new-build branch September 23, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants