-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New build #427
Conversation
should add to the documentation:
|
Now, css and modules are added using standard css3/es6 syntax. It works well with esm but not tested on old browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't dived too deeply into the details of the Rollup process yet, as I'd like to request these more ancillary changes first and then if all the editors are ready to be tested, I can check at that point.
But it generally looks good and more elegant if it meets the needs of all of our editors, and if the issues I raised can be addressed.
Yep, this was my intention to have a brief feedback from you. This will also takes some time before I can complete this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to import
sounds good if it will work (I can't remember why I didn't go this route). See my other comments.
I'm still struggling to find a way to configure Rollup properly for old browsers (nomodule). I think I progress slowly. I'm more familiar with webpack so would you have an issue if I test it on this one? |
Ugh--I'm sorry but Webpack really has struck me the times I've had to use it as unnecessarily complex, and that seems to be a common view. Webpack also doesn't support ESM distributions--only ESM source. What |
Ok. Let's stick to Rollup. |
may need to put it back later
improvements that were made to svgpathseg polyfill locally may have to be applied to the original package.
PR description
This PR has the goal to simplify the build process using the latest rollup/babel updates offering modern browsers light solution but also keeping support for older browsers.
We may also include in this PR some npm packages that are now imbedded in the project and not updated (which ultimately can cause bugs and security issues).
NOT READY TO MERGE BUT FOR INITIAL COMMENTS/CONTRIBUTIONS
Checklist
Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.
npm test
, ensuring linting passes and that Cypress UI tests keepcoverage to at least the same percent (reflected in the coverage badge
that should be updated after the tests run)
help both for future users and for the PR reviewer.