Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub codespace postCreateCommand issues #354

Open
klieret opened this issue May 15, 2024 · 1 comment · May be fixed by #868
Open

GitHub codespace postCreateCommand issues #354

klieret opened this issue May 15, 2024 · 1 comment · May be fixed by #868
Labels
✨ enhancement New feature or request 👋 good first issue Good for newcomers 🙏 help wanted Collaborators welcome!

Comments

@klieret
Copy link
Member

klieret commented May 15, 2024

postCreateCommand pulls the sweagent/swe-agent:latest docker image and runs other installation steps. However, it only starts a few seconds (to a minute) after the codespace starts, so if users already start running a command before that, things won't work.

Can we either:

  • Realize that we're in codespaces and this is happening and provide a very precise error message
  • Abandon postCreateCommand for some other setup stage (but that didn't work so far)
@klieret klieret added ✨ enhancement New feature or request 👋 good first issue Good for newcomers 🙏 help wanted Collaborators welcome! labels May 15, 2024
@Brandhash
Copy link

Can we add a warning msg to users, like a 1 minute countdown and a description for what's happening and why it is important to not enter any code before timer runs out.? I'm just spitballing here

erkinalp added a commit to erkinalp/SWE-agent that referenced this issue Dec 20, 2024
@devin-ai-integration @erkinalp
feat: prevent premature command execution in Codespaces
6abf583 
- Add setup status tracking script
- Modify postcreate.sh to use status tracking
- Add status checking in CLI
- Update documentation with clearer setup instructions

Fixes SWE-agent#354

Co-Authored-By: Erkin Alp Güney <[email protected]>
erkinalp added a commit to erkinalp/SWE-agent that referenced this issue Dec 20, 2024
@devin-ai-integration @erkinalp
feat: prevent premature command execution in Codespaces
425f751 
- Add setup status tracking script
- Modify postcreate.sh to use status tracking
- Add status checking in CLI
- Update documentation with clearer setup instructions

Fixes SWE-agent#354

Co-Authored-By: Erkin Alp Güney <[email protected]>
@erkinalp erkinalp linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement New feature or request 👋 good first issue Good for newcomers 🙏 help wanted Collaborators welcome!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: prevent premature command execution in Codespaces erkinalp/SWE-agent
2 participants
@klieret @Brandhash