Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to various "gain constant ability" effects #788

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

AMMayberry1
Copy link
Collaborator

@AMMayberry1 AMMayberry1 commented Mar 5, 2025

Fixed a couple of subtle issues related to various effects granting a constant ability to the attached unit.

  • The Piloting helper was not correctly adding a zone filter to the gainCondition check, which can result in exceptions happening in some cases
  • In several cases we had mis-implemented an ability from an upgrade where it says the attached unit gains a constant ability targeting itself, and were instead using the upgrade as the ability source. This came up during testing for Kazuda since it has implications for how his ability impacts those cards. Should be fixed now.

@AMMayberry1 AMMayberry1 merged commit aed0ef9 into main Mar 5, 2025
2 checks passed
@AMMayberry1 AMMayberry1 deleted the ammayberry1/gain-ability-fixes branch March 5, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant