Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring swagger config #213

Conversation

hichri-louay
Copy link
Contributor

@hichri-louay hichri-louay commented May 25, 2023

PR Description

Hey team,

This pull request aims to improve the code structure and organization of the app.js file in our GitHub repository. The main objective is to enhance maintainability and readability by moving the Swagger configuration code to a separate file called setupSwagger.js. By doing this, we can achieve better separation of concerns and adhere to the single responsibility principle.

Changes Made

  • Created a new file called setupSwagger.js in the appropriate directory.
  • Transferred the Swagger configuration code from app.js to setupSwagger.js.
  • Updated the app.js file to import the necessary functions or configurations from setupSwagger.js.
  • Verified that the application remains functional after the code refactoring.

Notes for Reviewers

Please review the changes made in this pull request carefully, paying particular attention to the new setupSwagger.js file and the modifications in app.js. Any feedback, suggestions, or improvements are welcome

Best regards,
Louay HICHRI

@hichri-louay hichri-louay requested a review from ksibisamir May 25, 2023 10:30
@hichri-louay hichri-louay linked an issue May 25, 2023 that may be closed by this pull request
@ksibisamir ksibisamir merged commit 2a86742 into develop May 25, 2023
@ksibisamir ksibisamir deleted the 195-decouple-swagger-documentation-setup-from-main-application-file branch May 25, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple Swagger Documentation Setup from Main Application File
2 participants