Open LUKS containers before mounting volumes.

[dmatetelki]

As described in issue:
#25

[kernelOfTruth]

@cs0rbagomba

thanks for addressing this !

BUMP

[alinefr]

Some people may want to encrypt a single zvol instead of a pool. That's why git://anongit.gentoo.org/proj/genkernel.git tries to import a zpool before and after luks. So I did it here, trying to unlock before and after luks: alinefr/genkernel-next@489f9fe

[lxnay]

We should do both and call start_volumes before and after (need to check if start_volumes is idempotent though).
This because we may discover luks partitions only after start_volumes too.

[ptMuta]

The lack of integration of the simple fix by @alinefr forces me to use a custom build instead of the repository build... Could this be resolved after almost three years of pending solution? @mudler ?

[dmatetelki]

@ptMuta : I have to use custom genkernel builds too because of this.

Guys, can we have some progress?

[mudler]

start_volumes should be harmless and idempotent, but since this issue have been sitting here for ages we should take action - Let's test, keep it on master and wait later if someone will complain and file bugs ✨

[ptMuta]

Well it's not harmless if it renders using genkernel-next for LUKS encrypted ZFS roots absolutely useless, lol.

…

On Sun, Nov 26, 2017 at 11:19 PM Ettore Di Giacinto < ***@***.***> wrote: It should be harmless and idempotent, but since this issue have been sitting here for ages we should take action - Let's see later if someone will complain and file bugs ✨ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFLY2-0OWKc3Vgy-hednSFjPe73pEFKpks5s6dXjgaJpZM4DipSV> .

[mudler]

And that's why i said should

[lovesegfault]

Can this please be merged?

[dmatetelki]

It might be fixed already with: 5a1db22

which issues the 2 lines twice:

start_volumes
zfs_start_volumes

setup_keymap

# Initialize LUKS root device except for livecd's
is_livecd || start_luks

start_volumes
zfs_start_volumes

I haven't tasted if works.

[lovesegfault]

I tried it a little while back, but with no success