Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: implement one hot encoder and imputer using polars #768

Merged
merged 16 commits into from
May 15, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 15, 2024

Summary of Changes

The one hot encoder and imputer are now also implemented using polars, providing better performance.

Tests should pass again now. We'll maximize coverage over the coming days.

Copy link
Contributor

github-actions bot commented May 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 23 0 0 2.01s
✅ PYTHON mypy 23 0 3.87s
✅ PYTHON ruff 23 0 0 0.53s
✅ REPOSITORY git_diff yes no 0.56s
✅ YAML prettier 1 0 0 1.43s
✅ YAML v8r 1 0 3.67s
✅ YAML yamllint 1 0 0.27s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann marked this pull request as ready for review May 15, 2024 14:33
@lars-reimann lars-reimann requested a review from a team as a code owner May 15, 2024 14:33
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 98.87640% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.11%. Comparing base (0e5a54b) to head (317b9d9).
Report is 9 commits behind head on main.

Files Patch % Lines
src/safeds/data/tabular/containers/_table.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   99.91%   97.11%   -2.80%     
==========================================
  Files          81      107      +26     
  Lines        5772     5520     -252     
==========================================
- Hits         5767     5361     -406     
- Misses          5      159     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit e993c17 into main May 15, 2024
10 of 12 checks passed
@lars-reimann lars-reimann deleted the transformers-2 branch May 15, 2024 14:37
lars-reimann pushed a commit that referenced this pull request May 15, 2024
## [0.25.0](v0.24.0...v0.25.0) (2024-05-15)

### Features

* major API redesign (WIP) ([#752](#752)) ([8e781f9](8e781f9)), closes [#694](#694) [#699](#699) [#714](#714) [#748](#748)
* move NN converters and layers to separate packages ([#759](#759)) ([c6a4073](c6a4073))
* remove operations without replacement from tabular containers ([#747](#747)) ([0e5a54b](0e5a54b))
* specify partial order in label encoder ([#763](#763)) ([6fbe537](6fbe537)), closes [#639](#639)

### Bug Fixes

* Conversion of tabular dataset to tensors ([#757](#757)) ([9e40b65](9e40b65))
* fixed devices with new polars implementation ([#756](#756)) ([e72339e](e72339e))

### Performance Improvements

* implement one hot encoder and imputer using polars ([#768](#768)) ([e993c17](e993c17))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants