Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorten some excessively long names #787

Merged
merged 5 commits into from
May 17, 2024
Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 17, 2024

Closes #772

Summary of Changes

  • Attributes or parameters that describe a count/number of something now have the suffix _count instead of the prefix number_of.
  • Abbreviate maximum to max and minimum to min.
  • Update project guidelines.

@lars-reimann lars-reimann linked an issue May 17, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented May 17, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdown-link-check 5 0 2.02s
✅ PYTHON black 64 0 0 2.68s
✅ PYTHON mypy 64 0 4.2s
✅ PYTHON ruff 64 0 0 0.33s
✅ REPOSITORY git_diff yes no 0.54s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.24%. Comparing base (ee8acf7) to head (75c0022).
Report is 75 commits behind head on main.

Files Patch % Lines
...ds/data/tabular/containers/_lazy_vectorized_row.py 50.00% 1 Missing ⚠️
src/safeds/data/tabular/containers/_row.py 50.00% 1 Missing ⚠️
...safeds/data/tabular/transformation/_discretizer.py 88.88% 1 Missing ⚠️
src/safeds/ml/metrics/_regression_metrics.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files         107      107           
  Lines        5519     5519           
=======================================
  Hits         5367     5367           
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann force-pushed the 772-shorten-some-names branch from 92851ac to 1386f51 Compare May 17, 2024 19:37
@lars-reimann lars-reimann force-pushed the 772-shorten-some-names branch from 1386f51 to 93d6052 Compare May 17, 2024 19:40
@lars-reimann lars-reimann marked this pull request as ready for review May 17, 2024 19:44
@lars-reimann lars-reimann merged commit 1c3ea59 into main May 17, 2024
11 of 12 checks passed
@lars-reimann lars-reimann deleted the 772-shorten-some-names branch May 17, 2024 19:58
lars-reimann pushed a commit that referenced this pull request May 29, 2024
## [0.26.0](v0.25.0...v0.26.0) (2024-05-29)

### Features

* `Table.count_row_if` ([#788](#788)) ([4137131](4137131)), closes [#786](#786)
* added method to load pretrained models from huggingface ([#790](#790)) ([dd8394b](dd8394b))
* infer input size of forward and LSTM layers ([#808](#808)) ([098a07f](098a07f))
* outline around dots of scatterplot ([#785](#785)) ([ee8acf7](ee8acf7))
* remove output conversions ([#792](#792)) ([46f2f5d](46f2f5d)), closes [#732](#732)
* shorten some excessively long names ([#787](#787)) ([1c3ea59](1c3ea59)), closes [#772](#772)
* specify column names in constructor of table transformers ([#795](#795)) ([69a780c](69a780c))
* store window size and forecast horizon in dataset ([#794](#794)) ([f07bc5a](f07bc5a))
* string operations on cells ([#791](#791)) ([4a17f76](4a17f76))

### Bug Fixes

* handling of boolean columns in column statistics ([#778](#778)) ([f61cceb](f61cceb))
* sort x values of line plot ([#782](#782)) ([74d8649](74d8649))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten some names
2 participants