ScoverageSensor: Don't prepend project name to sonar.sources #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gacko
changed the title
|
@Gacko hello, I'll have a look later today. |
|
Any progress on this? |
|
ping |
|
Hello, Sorry for the delay and LGTM, it just took a while for me to find the 30 minutes to understand all the implications of this change :) |
|
Ah, fine. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already proposed this change to @RadoBuransky but he does not seem to be very active at the moment. So I'll just propose it here, too.
The configuration key for the sources of a single-module project does not contain the project name but this is what's currently happening when the sources path is looked up.
The project name may vary since Sonar Scanner appends the VCS branch name to the project name. So I would have to configure a sources configuration key for every branch while the original sonar.sources configuration key is never used - neither in single- nor in multi-module projects.
This change omits the inclusion of the project name into the sources path lookup.