Skip to content

Commit

Permalink
Add some todos.
Browse files Browse the repository at this point in the history
  • Loading branch information
wjhsf committed Jan 18, 2023
1 parent 06c4a0f commit 3bd96c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/actions/publish_to_npm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ input:
runs:
using: composite
steps:
# TODO: Remove --dry-run
- name: Publish to NPM
run: |-
# Add NPM token to allow publishing
Expand Down
3 changes: 2 additions & 1 deletion .github/actions/unit_tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ runs:
using: composite
steps:
- name: Run tests step
# TODO - The pipefile policy is from CircleCI. Is it still needed for GitHub Actions?
run: |-
# Explicitly set pipefile policy. This is the default for non-windows, but seems
# that is needs to be set on windows to fail immediately.
Expand All @@ -16,7 +17,7 @@ runs:
cd ${{ inputs.cwd }}
# Note: Each of these test commands need to be exposed on the monorepo
# root and *also* on the PWA package. This section is run on both.
# root and *also* on the template package. This section is run on both.
# Ensure bundlesize is in check
npm run test:max-file-size
Expand Down

0 comments on commit 3bd96c0

Please sign in to comment.