Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions #854

Merged
merged 111 commits into from
Jan 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
508efeb
Add test workflow
adamraya Nov 24, 2022
138e7f2
Use actions/checkout v3
adamraya Nov 24, 2022
7161c2e
Don't use CI image
adamraya Nov 24, 2022
ec1eb72
Add step install npm dependencies
adamraya Nov 24, 2022
1f30c0c
Add setup action
adamraya Nov 24, 2022
e87d3fd
Set DEVELOP and RELEASE env variables
adamraya Nov 25, 2022
18ecc57
Add required shell property
adamraya Nov 25, 2022
25145bc
Update action.yml
adamraya Nov 25, 2022
1c5e5d0
Update action.yml
adamraya Nov 25, 2022
e67228b
Adding test matrix
adamraya Nov 25, 2022
efda39f
cleanup
adamraya Nov 25, 2022
b09e56e
Split setup windows and ubuntu
adamraya Nov 25, 2022
0177e40
Update test.yml
adamraya Nov 25, 2022
a9fb5a5
Update test.yml
adamraya Nov 25, 2022
6200507
Add Lighthouse and smoketest scripts
adamraya Nov 25, 2022
f62331c
Not using actions/cache for now
adamraya Nov 25, 2022
7c6d4ba
Add generated matrix
adamraya Nov 25, 2022
c5599ba
Add missing runs-on prop to generated matrix
adamraya Nov 25, 2022
ced3e25
Add Setup Node step to generated matrix
adamraya Nov 25, 2022
1582e73
Add Setup machine to generated matrix
adamraya Nov 25, 2022
0c04857
Add cron schedule
adamraya Nov 25, 2022
41e8006
Add timeout-minutes 5
adamraya Nov 29, 2022
201e538
Move timeout to generate project step
adamraya Nov 29, 2022
59d3246
Merge branch 'develop' into github-actions
adamraya Nov 29, 2022
ed0814e
Add Run tests on generated projects
adamraya Nov 29, 2022
f022323
Use dynamic generated-project folder
adamraya Nov 29, 2022
65fd8cb
Run tests on test-project and retail-react-app-demo
adamraya Dec 1, 2022
26384f6
Add Push Bundle step
adamraya Dec 1, 2022
7501145
Skip flaky test
adamraya Dec 1, 2022
83a3ca8
Disable fail-fast strategy
adamraya Dec 1, 2022
f6df46a
Use env variables
adamraya Dec 1, 2022
f51b67d
Re-arrange env
adamraya Dec 1, 2022
4823ca8
Add step before push bundle
adamraya Dec 5, 2022
a510e95
cleanup
adamraya Dec 5, 2022
177ca78
Merge branch 'develop' into github-actions
adamraya Dec 5, 2022
250ab24
cleanup
adamraya Dec 5, 2022
e3bcfc1
Use temp test-env-3
adamraya Dec 5, 2022
1af8920
testing slack notifs
yunakim714 Jan 9, 2023
e71cf33
testing
yunakim714 Jan 9, 2023
15145fc
add publish to npm step
yunakim714 Jan 9, 2023
cbd5458
fix indent
yunakim714 Jan 9, 2023
32f8344
python-dev does not exist anymore
yunakim714 Jan 9, 2023
c8169b1
Merge branch 'develop' into github-actions
yunakim714 Jan 9, 2023
f4be04f
use python2
yunakim714 Jan 9, 2023
9689db8
Merge branch 'github-actions' of github.com:SalesforceCommerceCloud/p…
yunakim714 Jan 9, 2023
8d8f44b
increase max packages
yunakim714 Jan 10, 2023
abcdfa9
test slack notifs
yunakim714 Jan 10, 2023
8e25822
add snyk cli and datadog step
yunakim714 Jan 10, 2023
d479fbe
update mrt user credentials
yunakim714 Jan 10, 2023
4644814
testing slack with pwa kit channel
yunakim714 Jan 10, 2023
feedcf2
syntax
yunakim714 Jan 10, 2023
35936c3
fix conditionals
yunakim714 Jan 10, 2023
2d77717
test push bundle
yunakim714 Jan 10, 2023
9f0ecbd
add push bundle step for generated
yunakim714 Jan 11, 2023
703fc1d
syntax
yunakim714 Jan 11, 2023
41bce12
fix syntax error
yunakim714 Jan 11, 2023
53caf68
update slack payload
yunakim714 Jan 11, 2023
81fa754
run steps in container
yunakim714 Jan 12, 2023
412bc8c
testing
yunakim714 Jan 12, 2023
ff3c7f5
refactor
yunakim714 Jan 12, 2023
f1ba8af
syntax
yunakim714 Jan 12, 2023
9eb9bed
sudo container error
yunakim714 Jan 12, 2023
7be6e20
testing
yunakim714 Jan 12, 2023
5c62465
update
yunakim714 Jan 12, 2023
f942c0f
add pip
yunakim714 Jan 12, 2023
e761166
use different docker
yunakim714 Jan 12, 2023
533a0af
no container
yunakim714 Jan 12, 2023
ca7becc
container
yunakim714 Jan 12, 2023
029026c
testing
yunakim714 Jan 12, 2023
4eca5d1
add user to container
yunakim714 Jan 13, 2023
ea90253
fix
yunakim714 Jan 13, 2023
3aaa51c
syntax add shell
yunakim714 Jan 13, 2023
93f0d94
syntax errors
yunakim714 Jan 13, 2023
1c91aff
remove container, use act
yunakim714 Jan 13, 2023
be5b133
syntax errors
yunakim714 Jan 13, 2023
8449e3e
add snyk audit and other syntax stuff
yunakim714 Jan 13, 2023
95d2ec7
extract steps to own actions
yunakim714 Jan 13, 2023
a59f27e
add inputs for actions
yunakim714 Jan 17, 2023
8d1f5ca
add shell for steps in actions with run
yunakim714 Jan 17, 2023
4e00037
project cannot be generated in action file
yunakim714 Jan 17, 2023
3ccdf88
updated snyk token, uncommenting code
yunakim714 Jan 17, 2023
e9b35c2
Fix typo.
wjhsf Jan 17, 2023
55cbc0a
Add missing appkey property.
wjhsf Jan 17, 2023
f15a79a
Use snake_case names for legibility.
wjhsf Jan 18, 2023
f48f021
Restore missing clean check
wjhsf Jan 18, 2023
ad5dd74
Fix skipped conversion to snake_case.
wjhsf Jan 18, 2023
7609b54
Trim trailing whitespace.
wjhsf Jan 18, 2023
b14122d
Extract conditionals to vars and clean up vars.
wjhsf Jan 18, 2023
bddcecc
Change env IS_TESTABLE_TEMPLATE to more clear IS_TEMPLATE_FROM_RETAIL…
wjhsf Jan 18, 2023
ecb9076
Fix YAML breaking conditional.
wjhsf Jan 18, 2023
7e7ee77
Try explicitly checking value.
wjhsf Jan 18, 2023
52ca0e2
Try explicitly checking true/false string values.
wjhsf Jan 18, 2023
dc57cb5
Try string comparisons.
wjhsf Jan 18, 2023
5ab6e66
Fix bad YAML.
wjhsf Jan 18, 2023
a0dba1a
Replace " with '
wjhsf Jan 18, 2023
90b3e02
Get ready for the prime time!
wjhsf Jan 18, 2023
92ee60c
Merge branch 'develop' into github-actions
wjhsf Jan 19, 2023
6c39641
Fail fast!
wjhsf Jan 19, 2023
0c58c50
Update TODOs.
wjhsf Jan 19, 2023
b9c998e
Clean up npm version management.
wjhsf Jan 19, 2023
8723348
Add TODO to merge workflows.
wjhsf Jan 19, 2023
98266b0
Update step names.
wjhsf Jan 19, 2023
e792908
End files with newline.
wjhsf Jan 19, 2023
add38c2
Run on pull_request to support forked repos.
wjhsf Jan 19, 2023
7921382
Only run on push for develop/release.
wjhsf Jan 19, 2023
50d9b1a
Merge branch 'develop' into github-actions
wjhsf Jan 19, 2023
16e9580
Only push to MRT when actually desired.
wjhsf Jan 19, 2023
c7ed577
Get that JavaScript nonsense outta here!
wjhsf Jan 19, 2023
eab1a2b
Check DEVELOP in step conditional, not in action execution.
wjhsf Jan 19, 2023
26e0874
Add some TODOs.
wjhsf Jan 19, 2023
c23ea6c
Too many newlines!
wjhsf Jan 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add push bundle step for generated
yunakim714 committed Jan 11, 2023
commit 9f0ecbdef30894fc6b73ee35f601de4087d074b1
33 changes: 27 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -94,10 +94,6 @@ jobs:
if [[ $target_commerce_sdk_react ]]; then
npm run push --prefix packages/test-commerce-sdk-react -- -s $project --message "test-commerce-sdk-react build ${{ github.run_id }} on ${{ github.ref }} (${{ github.sha }})" --target $target_commerce_sdk_react
fi
- name: test fail
id: demo
if: ${{ matrix.os == 'ubuntu-latest' && matrix.npm == 6 }}
run: exit 1
#TODO: remove --dry-run from install command
- name: Publish to NPM
if: github.repository == 'SalesforceCommerceCloud/pwa-kit' && matrix.npm == 6 && matrix.os == 'ubuntu-latest'
@@ -119,7 +115,7 @@ jobs:
#TODO: change github-actions to develop
- name: Send GitHub Action data to Slack workflow (PWA Kit)
id: slack
if: ${{ failure() && github.ref == 'refs/heads/github-actions' && matrix.npm == 6 && matrix.os == 'ubuntu-latest' }}
if: ${{ github.repository == 'SalesforceCommerceCloud/pwa-kit' && failure() && github.ref == 'refs/heads/github-actions' && matrix.npm == 6 && matrix.os == 'ubuntu-latest' }}
uses: slackapi/[email protected]
with:
payload: |
@@ -201,9 +197,34 @@ jobs:
dog metric post mobify_platform_sdks.generated_project_total_packages $TOTAL_PACKAGES
env:
DATADOG_API_KEY: ${{ secrets.DATADOG_API_KEY }}
- name: Create MRT credentials file
if: github.repository == 'SalesforceCommerceCloud/pwa-kit' && (matrix.template == 'test-project' || matrix.template == 'retail-react-app-demo') && matrix.os == 'ubuntu-latest'
env:
MOBIFY_CLIENT_USER: ${{ secrets.MOBIFY_CLIENT_USER }}
MOBIFY_CLIENT_API_KEY: ${{ secrets.MOBIFY_CLIENT_API_KEY }}
run: |-
# Add credentials file at ~/.mobify so we can upload to Mobify Cloud
npm run save-credentials --prefix packages/template-retail-react-app -- --user "$MOBIFY_CLIENT_USER" --key "$MOBIFY_CLIENT_API_KEY"
shell: bash
- name: Push Bundle
if: github.repository == 'SalesforceCommerceCloud/pwa-kit' && (matrix.template == 'test-project' || matrix.template == 'retail-react-app-demo') && matrix.os == 'ubuntu-latest'
run: |
if [[ $DEVELOP ]]; then
target='generated-pwa'
else
target=""
fi

project="scaffold-pwa"

if [[ $target ]]; then
cd generated-project

npm run push -- -s $project --message "Generated PWA build ${{ github.run_id }} on ${{ github.ref }} (${{ github.sha }})" --target $target
fi
- name: Send GitHub Action data to Slack workflow (Generated)
id: slack
if: ${{ failure() && github.ref == 'refs/heads/github-actions' && (matrix.template == 'test-project' || matrix.template == 'retail-react-app-demo') && matrix.os == 'ubuntu-latest' }}
if: ${{ github.repository == 'SalesforceCommerceCloud/pwa-kit' && failure() && github.ref == 'refs/heads/github-actions' && (matrix.template == 'test-project' || matrix.template == 'retail-react-app-demo') && matrix.os == 'ubuntu-latest' }}
uses: slackapi/[email protected]
with:
payload: |