fix(retail-react-app): recent searches #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add missing `return` to recent searches filter method + Add test cases for recent search storage
breadadams
commented
Feb 8, 2023
Comment on lines
-33
to
-40
| test('renders Popover if recent searches populated', async () => { | ||
| renderWithProviders(<SearchInput />) | ||
| const searchInput = document.querySelector('input[type="search"]') | ||
| await user.type(searchInput, 'Dresses') | ||
| expect(await screen.findByTestId('sf-suggestion')).toBeInTheDocument() | ||
| const countOfSuggestions = await screen.findAllByText('Dresses') | ||
| expect(countOfSuggestions.length).toEqual(2) | ||
| }) |
There was a problem hiding this comment.
I've removed this test as it seems it's sort of a duplicate of "shows previously searched items when focused" (L45).
wjhsf
approved these changes
Feb 8, 2023
|
@breadadams thank you for fixing it and writing the tests too 🙏 |
bfeister
added a commit
that referenced
this pull request
Feb 16, 2023
* develop: (52 commits) fix localstorage key by add siteId prefix (#988) [Shopper Experience] `ImageTile` component (#967) Skip Snyk CLI (#983) fix(retail-react-app): recent searches (#969) [Feature] Shopper Experience / Page Designer Components (#963) fix(template-retail-react-app): improved handling of blocked einstein requests (#970) remove getResetPasswordToken from not implemented list (#973) Apply changes from commerce react sdk in feature branch (#964) Add Shopper Experience hooks (#958) chore: update pwa-kit-dev eslint config (#950) Serialize category data once only (#953) Fix layout shift for mega menu (#952) Update customer baskets cache when there is a basket mutation (#945) Remove the PersistentCache functionality (#949) Replace isomorphic jest mocks with msw handlers (#944) fix: handle special characters in `boldString` util (#942) Fix broken CI – confusing path to package.json in the 'dist' directory! (#946) @W-11920099 Re-write 'npm push' in Typescript, warn if Node deprecated (#763) Allow support for multiple sites concurrently w/ `commerce-sdk-react` (#911) Update `develop` with v2.6.0 (#939) ... # Conflicts: # lerna.json # package-lock.json # package.json # packages/commerce-sdk-react/CHANGELOG.md # packages/commerce-sdk-react/package-lock.json # packages/commerce-sdk-react/package.json # packages/internal-lib-build/package-lock.json # packages/internal-lib-build/package.json # packages/pwa-kit-create-app/package-lock.json # packages/pwa-kit-create-app/package.json # packages/pwa-kit-dev/CHANGELOG.md # packages/pwa-kit-dev/bin/pwa-kit-dev.js # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-dev/package.json # packages/pwa-kit-react-sdk/CHANGELOG.md # packages/pwa-kit-react-sdk/package-lock.json # packages/pwa-kit-react-sdk/package.json # packages/pwa-kit-react-sdk/src/ssr/browser/main.jsx # packages/pwa-kit-runtime/CHANGELOG.md # packages/pwa-kit-runtime/package-lock.json # packages/pwa-kit-runtime/package.json # packages/template-express-minimal/package-lock.json # packages/template-express-minimal/package.json # packages/template-retail-react-app/app/commerce-api/mock-data.js # packages/template-retail-react-app/package-lock.json # packages/template-retail-react-app/package.json # packages/template-typescript-minimal/package-lock.json # packages/template-typescript-minimal/package.json # packages/test-commerce-sdk-react/package-lock.json # packages/test-commerce-sdk-react/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #968
Types of Changes
Changes
returnto recent searches filter methodHow to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization