feat: potentiometer toggle in rules.mk #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier for me to explain this in a PR than in the comments of your PR, especially since it involves creating a new
post_rules.mkfile.These changes allow your users to enable or disable the potentiometer by setting
POT_ENABLE = yes(orPOT_ENABLE = no) in their own keymap'srules.mkfile.Only if the user has enabled the potentiometer does the build then include
analog.c-- it isn't needed otherwise. This saves space.I don't think any of what you've got now is wrong (though you have submitted it on your master branch, which means you will need to jump through some hoops later) ...but this will make it better.
...Just be aware that based on how long the line is, I have no idea if you'll make it before the breaking changes cutoff at the end of the month. If not, you'll probably be asked to make some changes to the RGB config and the encoders.