-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'preserve' argument #20
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR Chien! This is a popular request so thanks for putting together a PR. I do believe having 3 arguments for this would be the most flexible approach. Here is my rational. Your specific usecase requires opting-out of the delete step... But what about the replace? Are you okay with that running? Will other use cases? So I'm thinking 3 props. Basically allowing people to opt out of any given step to fit their specific usecase. We could default these to Also we should keep this logic with the hash diff implementation (I think). I'm on mobile right now so it's hard to say without looking at the codebase. |
Currently, the argument I guess The default value for them would be In this case
I don't know how glob pattern works exactly but that's the best I can think of. |
This reverts commit dd71a3b.
As for implementation we can skip processing files based on the users settings in this file. Line 65 in f79bd10
|
Yup exclude is kinda overcomplicated. My current use cases only require basic true/false activation.
Working on it! |
So you will update on FTP-Deploy-Action, too? |
Hi @SamKirkland , Please checkout 085feeb |
When this option will be available, it' still open ? |
Any updates on this really useful feature? Seems it's still not merged. |
New argument:
preserve
boolean
false
true