feat: add same positions for gagn #1655
Conversation
| @@ -1240,11 +1240,15 @@ class RecruitmentApplicationForRecruitersView(APIView): | |||
|
|
|||
| def get(self, request: Request, application_id: str) -> Response: | |||
| application = get_object_or_404(RecruitmentApplication, id=application_id) | |||
| same_gang_applications = RecruitmentApplication.objects.filter( | |||
There was a problem hiding this comment.
Kan vi ikke bare gjøre dette i frontend heller? Alle andre søknader er tilgjengelig i other_applications. I frontend kan vi bruke denne og bare filtrere etter gjeng
There was a problem hiding this comment.
Mer praktisk å holde slik filtrering i backend en frontend, vil sette minst mulig komputasjon i frontend. Gjør det bedre senere, gjør det bedre for posting i dette tilfellet som kommer senere
There was a problem hiding this comment.
Jeg er enig i at vi man heller burde filtrer dette i backend, men da trenger vi selvfølgelig ikke sende med
other_applications i applications objektet.
| @@ -1240,11 +1240,15 @@ class RecruitmentApplicationForRecruitersView(APIView): | |||
|
|
|||
| def get(self, request: Request, application_id: str) -> Response: | |||
| application = get_object_or_404(RecruitmentApplication, id=application_id) | |||
| same_gang_applications = RecruitmentApplication.objects.filter( | |||
There was a problem hiding this comment.
Jeg er enig i at vi man heller burde filtrer dette i backend, men da trenger vi selvfølgelig ikke sende med
other_applications i applications objektet.
| @@ -1240,11 +1240,15 @@ class RecruitmentApplicationForRecruitersView(APIView): | |||
|
|
|||
| def get(self, request: Request, application_id: str) -> Response: | |||
| application = get_object_or_404(RecruitmentApplication, id=application_id) | |||
| same_gang_applications = RecruitmentApplication.objects.filter( | |||
| user=application.user, recruitment=application.recruitment, recruitment_position__gang=application.recruitment_position.resolve_gang() | |||
| ).order_by('applicant_priority') | |||
| other_applications = RecruitmentApplication.objects.filter(user=application.user, recruitment=application.recruitment).order_by('applicant_priority') | |||
There was a problem hiding this comment.
Da kan vel dette endres slik at det ikke inneholder søkander i denne gjengen?
Just a small fix needed for on applicant and gang manage as done in samf3