Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't hide time codes in portrait or narrow window #294

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

Samillion
Copy link
Owner

@Samillion Samillion commented Jan 5, 2025

Instead of hiding the time codes, move them above play controls, centered.

Centered above play controls is the best fit, as these buttons do not have tooltips and places the essential elements centered so even in abnormal narrow videos or window, they're displayed.

timecodes_portrait_videos.mp4

Instead of hiding the time codes, move them above play controls, centered.
@Samillion
Copy link
Owner Author

CC: @Keith94 @BODZy @jiangzhenjerry
Sorry for the random ping, looking for feedback on this PR before I merge, Only if it's not a bother.

Test script: portrait_videos_tc/modernz.lua

@Keith94
Copy link
Contributor

Keith94 commented Jan 5, 2025

That's an awesome idea. I definitely approve.

You might see a clash/overlap of elements with larger font sizes (such as 18) or when milliseconds are enabled.

image

@Samillion
Copy link
Owner Author

True! I did not think of that. I'll apply a fix for that one in a different PR, thank you so much for pointing it out. Completely slipped my mind.

@jiangzhenjerry
Copy link

Thanks for pinging. So far so good on my end. time_font_size >=20 may make it look a little crowded for portrait videos but 18 and below works well. Love it.

@Samillion
Copy link
Owner Author

Awesome, thank you for confirming. I'll apply a PR fix for time state and font size after merging this one.

@Samillion
Copy link
Owner Author

Merging. Follow up on the other issues here: #295

@Samillion Samillion merged commit d21d00f into main Jan 5, 2025
@Samillion Samillion deleted the dev_portrait_timecodes branch January 5, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants