Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: when osc visibility is set to always, apply osc margins to show menus above it #303

Merged
merged 9 commits into from
Jan 12, 2025

Conversation

Samillion
Copy link
Owner

@Samillion Samillion commented Jan 11, 2025

Fixes: #302

  • Use osc margins to show select menus and console above osc, when visibility=always
  • Change z depth of osc to 1000 instead of -1
  • When osc is visible, don't spam margins (verbose)
  • Don't force hide osc with menus if osc visibility is set to always
  • Remove unnecessary request_init() calls within osc_init()
  • Apply osc margins within osc_init()
  • Add cache_enabled() helper
  • Don't use margins if osc is visible only temporarily
  • Update chapter title to the current playing chapter
    • Since request_init() was used to update it (not sure why), it stopped working after its removal. Simply letting the content function handle it resolves the issue.
  • Show cache_info tooltip on hover using the new cache helper function

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Since request_init() was used to update (not sure why), it stopped working after its removal.

But simply letting the content function handle it resolves the issue.
@Samillion Samillion changed the title feat: when osc is visible apply margins to show menus above it feat: when osc visibility is set to always, apply osc margins to show menus above it Jan 11, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Samillion Samillion merged commit 0ae0a87 into main Jan 12, 2025
@Samillion Samillion deleted the dev_osc_margins_feat branch January 12, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When osc visibility is set to always, apply margins to show select menus above it
2 participants