[Tizen.Applications.RPCPort] Add new methods to support new types in tidl #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pjh9216 <[email protected]>
Signed-off-by: pjh9216 <[email protected]>
Internal API ChangedAdded: 8, Removed: 0, Changed: 0Added+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.SByte Tizen.Applications.RPCPort.Parcel::ReadSByte()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt16 Tizen.Applications.RPCPort.Parcel::ReadUShort()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt32 Tizen.Applications.RPCPort.Parcel::ReadUInt()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.Applications.RPCPort.Parcel::ReadULong()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteSByte(System.SByte)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteUInt(System.UInt32)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteULong(System.UInt64)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteUShort(System.UInt16)
|
upple
approved these changes
Dec 31, 2024
Internal API ChangedAdded: 8, Removed: 0, Changed: 0Added+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.SByte Tizen.Applications.RPCPort.Parcel::ReadSByte()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt16 Tizen.Applications.RPCPort.Parcel::ReadUShort()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt32 Tizen.Applications.RPCPort.Parcel::ReadUInt()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.Applications.RPCPort.Parcel::ReadULong()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteSByte(System.SByte)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteUInt(System.UInt32)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteULong(System.UInt64)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteUShort(System.UInt16)
|
hjhun
reviewed
Jan 1, 2025
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public ushort ReadUShort() | ||
| { | ||
| var bytes = Read(2); |
There was a problem hiding this comment.
How about using sizeof operator to get size of the type?
Signed-off-by: pjh9216 <[email protected]>
Internal API ChangedAdded: 8, Removed: 0, Changed: 0Added+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.SByte Tizen.Applications.RPCPort.Parcel::ReadSByte()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt16 Tizen.Applications.RPCPort.Parcel::ReadUShort()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt32 Tizen.Applications.RPCPort.Parcel::ReadUInt()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.Applications.RPCPort.Parcel::ReadULong()
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteSByte(System.SByte)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteUInt(System.UInt32)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteULong(System.UInt64)
+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.Applications.RPCPort.Parcel::WriteUShort(System.UInt16)
|
lwc0917
pushed a commit
to lwc0917/TizenFX
that referenced
this pull request
Jan 7, 2025
…tidl (Samsung#6536) * Add new methods to support new types in tidl Signed-off-by: pjh9216 <[email protected]> * Add attributes for internal APIs Signed-off-by: pjh9216 <[email protected]> * Use sizeof operator Signed-off-by: pjh9216 <[email protected]> --------- Signed-off-by: pjh9216 <[email protected]>
jaehyun0cho
pushed a commit
that referenced
this pull request
Jan 7, 2025
…tidl (#6536) * Add new methods to support new types in tidl Signed-off-by: pjh9216 <[email protected]> * Add attributes for internal APIs Signed-off-by: pjh9216 <[email protected]> * Use sizeof operator Signed-off-by: pjh9216 <[email protected]> --------- Signed-off-by: pjh9216 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add new parcel methods to support new types (u8, u16, u32, u64) in tidl