-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion `isExtensible() || newLength <= getArrayLength(state)' failed in Escargot::ArrayObject::setArrayLength #33
Comments
DanielBallaSZTE
pushed a commit
to DanielBallaSZTE/escargot
that referenced
this issue
Jan 2, 2019
…unction Fixes Samsung#33 Signed-off-by: Daniel Balla [email protected]
DanielBallaSZTE
pushed a commit
to DanielBallaSZTE/escargot
that referenced
this issue
Jan 2, 2019
…unction Fixes Samsung#33 Signed-off-by: Daniel Balla [email protected]
DanielBallaSZTE
pushed a commit
to DanielBallaSZTE/escargot
that referenced
this issue
Jan 2, 2019
…unction Fixes Samsung#33 Signed-off-by: Daniel Balla [email protected]
DanielBallaSZTE
pushed a commit
to DanielBallaSZTE/escargot
that referenced
this issue
Jan 2, 2019
…tion There's no need to put an assertion there because: - The ArrayObject's length can be changed even when it's not extensible, it just fills the Array with empty values. - Modifying the length of an ArrayObject should not throw an error, the only time it should when an element is pushed to a non-extensible ArrayObject. Fixes Samsung#33 Signed-off-by: Daniel Balla [email protected]
For the records: executing the test case both in Safari and in Chrome, extended with an extra |
yichoi
pushed a commit
that referenced
this issue
Jan 4, 2019
…tion (#34) There's no need to put an assertion there because: - The ArrayObject's length can be changed even when it's not extensible, it just fills the Array with empty values. - Modifying the length of an ArrayObject should not throw an error, the only time it should when an element is pushed to a non-extensible ArrayObject. Fixes #33 Signed-off-by: Daniel Balla [email protected]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Escargot version:
OS:
Test case:
Backtrace:
Found by Fuzzinator with grammarinator.
The text was updated successfully, but these errors were encountered: