Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isCallable check function according to call operation #290

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

clover2123
Copy link
Contributor

@clover2123 clover2123 commented Jun 18, 2019

  • isFunction is replaced with isCallable check function
  • call operations in Promise / TypedArray are fixed

Fixes #287
Fixes #288

Signed-off-by: HyukWoo Park [email protected]

@clover2123 clover2123 force-pushed the check_function branch 2 times, most recently from 352e1a7 to df62ef6 Compare June 19, 2019 05:42
* isFunction is replaced with isCallable check function
* call operations in Promise / TypedArray are fixed

Signed-off-by: HyukWoo Park <[email protected]>
Copy link
Contributor

@ksh8281 ksh8281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@haesik haesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haesik haesik merged commit 0671880 into Samsung:master Jun 19, 2019
@clover2123 clover2123 deleted the check_function branch July 15, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants