-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TV] Fixed descriptions for TV modules #1339
[TV] Fixed descriptions for TV modules #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
checkout the webpage https://docs1.stg.tizen.org/staging/1339 |
Check Broken Link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the API and descriptions are same in different versions for the file, I have left the comments only for first two files, kindly apply the same suggestions for all the files.
@@ -167,19 +167,19 @@ <h4 id="TV Controls">TV Controls</h4> | |||
<td>No</td> | |||
</tr> | |||
<tr><td><a href="tizen/tvinfo.html">TV Information</a></td> | |||
<td>This API allows receiving key events generated when the user presses a key of an Input Device (for example a TV remote control).</td> | |||
<td>This API provides interfaces and methods for getting information about TV settings.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API provides interfaces and methods to get information about the TV settings.
<td>2.3</td> | ||
<td>Optional</td> | ||
<td>Yes</td> | ||
</tr> | ||
<tr><td><a href="tizen/tvwindow.html">TV Window</a></td> | ||
<td>This API provides interfaces and methods for getting information about TV setting.</td> | ||
<td>This API provides interfaces and methods for control of TV Window (e.g. main window, PIP window).</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API provides interfaces and methods to control the TV Window. For example, the main window and PIP window.
@@ -11,7 +11,7 @@ | |||
<div class="supported-platforms"><img class="tv-optional" title="Optional, Not supported by Tizen Tv emulator" src="tv_s_w_optional.png"></div> | |||
<div class="title"><h1>TVInfo API</h1></div> | |||
<div class="brief"> | |||
The TVInfo API provides functions to get settings values that are provided by the Tizen TV. | |||
The TVInfo API provides interfaces and methods for getting information about TV settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TVInfo API provides interfaces and methods to get information about the TV settings.
<td>2.4</td> | ||
<td>Optional</td> | ||
<td>No</td> | ||
</tr> | ||
<tr><td><a href="tizen/tvinputdevice.html">TV Input Device</a></td> | ||
<td>This API provides interfaces and methods for control of TV Window (e.g. main window, PIP window).</td> | ||
<td>This API allows receiving key events generated when the user presses a key of an Input Device (for example a TV remote control).</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API allows to receive the key events generated from an input device . For example, when a user presses a key of the TV remote control.
@@ -176,19 +176,19 @@ <h4 id="TV Controls">TV Controls</h4> | |||
<td>No</td> | |||
</tr> | |||
<tr><td><a href="tizen/tvinfo.html">TV Information</a></td> | |||
<td>This API allows receiving key events generated when the user presses a key of an Input Device (for example a TV remote control).</td> | |||
<td>This API provides interfaces and methods for getting information about TV settings.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API provides interfaces and methods to get information about the TV settings.
<td>2.3</td> | ||
<td>Optional</td> | ||
<td>Yes</td> | ||
</tr> | ||
<tr><td><a href="tizen/tvwindow.html">TV Window</a></td> | ||
<td>This API provides interfaces and methods for getting information about TV setting.</td> | ||
<td>This API provides interfaces and methods for control of TV Window (e.g. main window, PIP window).</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API provides interfaces and methods to control the TV Window. For example, the main window and PIP window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkosko, gentle reminder to fix the comments.
@pkosko, gentle reminder to fix the comments. |
@annie-samsung I've modified descriptions according your comments, please check it. |
checkout the webpage https://docs1.stg.tizen.org/staging/1339 |
Check Broken Link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good hence approving
Issue: #1335
Fixed descriptions of TV modules - they were mixed up.