-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.3 Release #181
5.3 Release #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question where amazon-linux/Vagrantfile
has a different version (6.0) from the rest (5.3). Otherwise all looks fine.
amazon-linux/Vagrantfile
Outdated
@@ -63,7 +63,7 @@ Vagrant.configure("2") do |config| | |||
samuraiwtf.vm.provider "virtualbox" do |vb| | |||
# Display the VirtualBox GUI when booting the machine | |||
vb.gui = true | |||
vb.name = "SamuraiWTF-5.2" | |||
vb.name = "SamuraiWTF-6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this wouldn't be the same version as the Vagrantfile
at the root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 5.3 I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the one place we say 6.0 instead of 5.3 needs to be made consistent with the other changes before this is merged.
This is the pull request to make SamuraiWTF 5.3 the release. We will need to tag the files after accepting the PR.