Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUGGESTION] Config for specifying "2-handed" weapons. #15

Open
Noxalas opened this issue Jul 26, 2019 · 1 comment
Open

[SUGGESTION] Config for specifying "2-handed" weapons. #15

Noxalas opened this issue Jul 26, 2019 · 1 comment

Comments

@Noxalas
Copy link

Noxalas commented Jul 26, 2019 •
edited
Loading

Hello there!

Making a modpack and I would really like to let people dual-wield, but some weapons kind of don't make sense when it comes to size, and when you try to fire bows the off-hand also lands a hit at the same time. (Which feels kind of weird)

Is it possible to create a whitelist for items that are only usable when the other hand is empty?
@k1r0s
Copy link

k1r0s commented Nov 12, 2020

Would be more efficient just tell if the item in the mainhand even has a melee damage.

Example:

sword in the offhand - bow in the mainhand > left click will attack with the offhand
axe in the offhand - a block in the mainhand > left click will attack with the offhand
bow in the mainhand - bow in the mainhand > does what you expect on vanilla mc
bow in the mainhand - shield in the mainhand > does what you expect on vanilla mc
sword in the mainhand - shield in the mainhand > left click will attack with the offhand

k1r0s added a commit to k1r0s/BetterCombatRebirth that referenced this issue Nov 13, 2020
@k1r0s
fix SanAndreaP#15 and others
d44f19a 
First of all, I tried to make upstream work but it doens't so i was working locally with 37bf5fa (curseforge version)

didn't tested this too much (but it works somehow) so this is a suggestion pretty much.

Simply by checking if the "default action" has implemented means to do what the player expects rather than what Minecraft expects:

sword in the offhand - bow in the mainhand > left click will attack with the offhand
sword in the offhand - bow in the mainhand > right click will draw the bow in the mainhand (no attack with the offhand) SanAndreaP#15 (comment)
axe in the offhand - a block in the mainhand > left click will attack with the offhand
bow in the mainhand - bow in the mainhand > does what you expect on vanilla mc
bow in the mainhand - shield in the mainhand > does what you expect on vanilla mc
sword in the mainhand - shield in the mainhand > left click will attack with the offhand
@k1r0s k1r0s mentioned this issue Nov 13, 2020
Open
@democat3457 democat3457 mentioned this issue Jan 20, 2021
Merged
democat3457 added a commit to Rebirth-of-the-Night/BetterCombatRebirth that referenced this issue Jan 20, 2021
@democat3457
Merge pull request #1 from k1r0s/patch-1
b0e5b79 
fix SanAndreaP#15 and others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k1r0s @Noxalas