src: Fix bug in SHMEM_DEF_TEST_ALL #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidozog
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Very good catch @philipmarshall21! This is my bone-headed mistake I think.
Can you please check shmem_test_all_vector I think this bug is there as well.
philipmarshall21
force-pushed
the
pr/test_all_fix
branch
from
24c1a29 to
81e84e4
Compare
wrrobin
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
@philipmarshall21 - This one looks good. Please feel free to merge.
Regarding changes to the other APIs, I am not quite sure if that is applicable. Lets defer that to a later PR any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the shmem_test_all API does not account for elements that are suppose to be ignored (as set by the status argument) when determining the return value.