Fixed Off-by-one error in gethostname() #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should line99 be changed to add the NULL at +1? e.g. hostname[MAX_HOSTNAME_LEN] = '\0'; ==> 'hostname[MAX_HOSTNAME_LEN + 1] = '\0'; |
|
Good point let me look at those. |
markbrown314
force-pushed
the
issue-1159
branch
from
7bc5df6 to
c75c0eb
Compare
|
common.h::check_hostname_validation() will need to be fixed in the test-sos tree. |
MAX_HOSTNAME_LEN is the maximum total characters of the hostname not including the end of string character '\0'. If the hostname happens to be 64 characters long, gethostname() would return an error and shmem_runtime_util_put_hostname() would state error "gethostname failed (-1)" Changed length to MAX_HOSTNAME_LEN+1 Issue Sandia-OpenSHMEM#1159 Signed-off-by: Mark F. Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_HOSTNAME_LEN is the maximum total characters of the hostname not including the end of string character '\0'. If the hostname happens to be 64 characters long, gethostname() would return an error and shmem_runtime_util_put_hostname() would state error "gethostname failed (-1)"
Changed length to MAX_HOSTNAME_LEN+1
Issue #1159