fixes major code smells in GenericUtils.java (#372)

* fixes major code smells in GenericUtils.java * fixes major code smell * making classes GenericUtils and JSONSerializationUtils final
SasanLabs · Jul 15, 2022 · 93598e6 · 93598e6
1 parent 65656b1
commit 93598e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/main/java/org/sasanlabs/internal/utility/GenericUtils.java b/src/main/java/org/sasanlabs/internal/utility/GenericUtils.java
@@ -5,15 +5,18 @@
  *
  * @author KSASAN [email protected]
  */
-public class GenericUtils {
+public final class GenericUtils {
 
     public static final String LOCALHOST = "127.0.0.1";
 
+    private GenericUtils() {}
+
     /**
      * @deprecated
      * @param payload
      * @return
      */
+    @Deprecated
     public static String wrapPayloadInGenericVulnerableAppTemplate(String payload) {
         String generalPayload =
                 "<html><title>Security Testing</title><body><h1>Vulnerable Application </h1> %s </body></html>";

diff --git a/src/main/java/org/sasanlabs/internal/utility/JSONSerializationUtils.java b/src/main/java/org/sasanlabs/internal/utility/JSONSerializationUtils.java
@@ -13,10 +13,12 @@
  *
  * @author KSASAN [email protected]
  */
-public class JSONSerializationUtils {
+public final class JSONSerializationUtils {
 
     private static final ObjectMapper MAPPER = new ObjectMapper();
 
+    private JSONSerializationUtils() {}
+
     public static <T> String serialize(T object) throws JsonProcessingException {
         return MAPPER.writeValueAsString(object);
     }