Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSRF and DoS vulnerabilities #365

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

gled02
Copy link
Contributor

@gled02 gled02 commented Mar 21, 2022

As we discussed before, this PR comes from splitting PR #357 into two pull requests (the other PR is #364).
The main goal is to add SSRF and DoS vulnerabilities based on the user cases defined before.

Modifications like making some methods private or adding the contributor's name, have been made. We didn't change our implementation.

@preetkaran20
Copy link
Member

Hi @gled02 ,
can you please raise the PR against ssrf_unmerged branch. Why? so that we have your changes in our branches and we can merge them later.

1 similar comment
@preetkaran20
Copy link
Member

Hi @gled02 ,
can you please raise the PR against ssrf_unmerged branch. Why? so that we have your changes in our branches and we can merge them later.

@gled02 gled02 changed the base branch from master to ssrf_unmerged March 21, 2022 16:28
@gled02
Copy link
Contributor Author

gled02 commented Mar 21, 2022

Hi @preetkaran20 ,

I just raised the PR against ssrf_unmerged branch.

Thanks

@preetkaran20
Copy link
Member

Thanks !!!

@preetkaran20 preetkaran20 merged commit 8b1b87d into SasanLabs:ssrf_unmerged Mar 21, 2022
@preetkaran20
Copy link
Member

Hi @NMV01 , @gled02 ,
Thanks for the PRs for CSRF and SSRF vulnerabilities. I really like the speed at which you guys understood the codebase and the way you guys have done the changes. I am very impressed with your efforts, dedication, hard work, and approach.  I think after me if someone understands the VulnerableApp's codebase is you guys. This is the biggest contribution by anyone to the VulnerableApp and it has really helped VulnerableApp cover another set of Vulnerabilities. Hopefully, we will again collaborate in the future.
Also wanted to add that, I was not aware of the timelines else we could have handled it a little differently.
Also, we are looking for feedback about development experience, project improvements, any other thoughts, etc, if you have any please raise the Github issues or send me a mail.

Regards 
Karan

@gled02
Copy link
Contributor Author

gled02 commented Mar 21, 2022

Hi @preetkaran20,

Thanks a lot for your comments. We are really happy to have been able to contribute to VulnerableApp and to help the improvement of this useful project. We are glad to have chosen VulnerableApp as an open source project, for our university project. We learned a lot from this project and from your suggestions. @NMV01 and I, we will be happy to share ideas and thoughts in future.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants