Feature/issue 353 #382
Feature/issue 353 #382
Conversation
| run: ./gradlew jib | ||
| run: | | ||
| ./gradlew jib \ | ||
| -Djib.to.tags='latest',$GITVERSION_SEMVER |
There was a problem hiding this comment.
what would be GITVERSION_SEMVER?
There was a problem hiding this comment.
ok got it. can you please add few sample outputs of GITVERSION_SEMVER?
There was a problem hiding this comment.
Yup, and add the sample outputs to the README as the examples?
There was a problem hiding this comment.
Sample outputs of GITVERSION_SEMVER on DockerHub :
| @@ -20,9 +20,26 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| java-version: 1.8 | |||
| fetch-depth: 0 | |||
| - | |||
| name: Setup GitVersion action | |||
There was a problem hiding this comment.
can you please tell how will be mention Major and Minor? So we need to mention in PR name?
There was a problem hiding this comment.
i read your comment and it seems like we need to mention in commit message.
There was a problem hiding this comment.
can you please update the Readme with what we need to mention for major release and minor release? Also with example explain what is the impact of major release, minor release and Patch in the github tag and docker version ?
There was a problem hiding this comment.
ok will get this done
There was a problem hiding this comment.
@merry-degaga I merged this PR and I see that it has done a github release for the project where as i was thinking that it will just update the github tag and we will do the release as per our will.
https://github.com/SasanLabs/VulnerableApp/releases
is there a way we can stop it to create a release? From release, I point it as a major change so we notify about it in multiple channels.
There was a problem hiding this comment.
I deleted the release for now.
There was a problem hiding this comment.
Okay, I will take a look.
@merry-degaga please help with #382 (comment)
I will look into preventing auto-release creation.
There was a problem hiding this comment.
I was able to prevent auto-release creation.
…l to include VulnerableApp- in release name
|
@merry-degaga please help with |
Fixes: 353