Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] subscription page search field ui selector update #1709

Open
wants to merge 1 commit into
base: 6.16.z
Choose a base branch
from
Open

[6.16.z] subscription page search field ui selector update #1709

wants to merge 1 commit into from

Conversation

Satellite-QE
Copy link
Contributor

Cherrypick of PR: #1702

Problem Statement

  • Test case test_positive_access_with_non_admin_user_with_manifest was failing due to Error
    TypeError: 'NoneType' object is not subscriptable
  • Class variable search_field from airgun view SubscriptionSearch need to be updated

Solution

Update search_field with expected locator.

Robottelo PR

SatelliteQE/robottelo#17382

@vijaysawant @web-flow
subscription page search field ui selector update (#1702)
0b64903 
* subscription page search field ui selector update

* implemented PF4 related comments

* use SearchableViewMixinPF4 instead of SubscriptionSearchableViewMixin in class SearchableViewMixinPF4

(cherry picked from commit 4441e8d)
@Satellite-QE Satellite-QE added 6.16.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 22, 2025
@Satellite-QE
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'

@shweta83
Copy link
Contributor

shweta83 commented Feb 6, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_subscription.py -k 'test_positive_access_with_non_admin_user_with_manifest'

@Satellite-QE
Copy link
Contributor Author

PRT Result

Build Number: 492
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_subscription.py -k test_positive_access_with_non_admin_user_with_manifest --external-logging
Test Result : =========== 1 passed, 7 deselected, 16 warnings in 648.97s (0:10:48) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vijaysawant vijaysawant

Labels
6.16.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satellite-QE @shweta83 @vijaysawant